Guess updateinformation for GitHub Actions #13

probonopd · 2023-06-26T21:14:54Z

Compiles, but still needs to be tested for correctness.

#7 Compiles, but still needs to be tested for correctness.

probonopd · 2023-06-27T17:44:57Z

Now it is tested for correctness:

export GITHUB_TOKEN=...
export GITHUB_REPOSITORY=probono/AppImages
export GITHUB_REPOSITORY_OWNER=probono
./squashfs-root/AppRun ./squashfs-root/ -g --runtime-file runtime-x86_64

Guessing update information based on $GITHUB_REPOSITORY=probono/AppImages
gh-releases-zsync|probono|AppImages|latest|appimagetool*-x86_64.AppImage.zsync
Embedding MD5 digest
zsyncmake is available and updateinformation is provided, hence generating zsync file

src/appimagetool.c

* github_repository_name regardless of owner_start * Move comment above if statement

src/appimagetool.c

#13 (review)

TheAssassin · 2023-07-05T20:04:08Z

src/appimagetool.c

+                    if(zsyncmake_path){
+                        char buf[1024];
+                        // gh-releases-zsync|probono|AppImages|latest|Subsurface-*x86_64.AppImage.zsync
+                        sprintf(buf, "gh-releases-zsync|%s|%s|latest|%s*-%s.AppImage.zsync", github_repository_owner, github_repository_name, app_name_for_filename, arch);


Another sprintf.

#13 (comment)

src/appimagetool.c

TheAssassin · 2023-07-05T20:42:24Z

src/appimagetool.c

@@ -765,9 +765,9 @@ main (int argc, char *argv[])

            // if $VERSION is specified, we embed it into the filename
            if (version_env != NULL) {
-                sprintf(dest_path, "%s-%s-%s.AppImage", app_name_for_filename, version_env, arch);
+                snprintf(dest_path, "%s-%s-%s.AppImage", app_name_for_filename, version_env, arch);


Same as above, size missing.

src/appimagetool.c

TheAssassin · 2023-07-05T20:43:22Z

You don't need to fix the world in such a PR. New code should be good, though.

src/appimagetool.c

TheAssassin · 2023-07-05T23:12:52Z

I have not seen any major issues any more. But I guess I should run a real world test, too. Will approve once done.

TheAssassin

Seems to work in the real world, too. Thanks. Feel free to merge.

Guess updateinformation for GitHub Actions

d5456a4

#7 Compiles, but still needs to be tested for correctness.

probonopd requested a review from TheAssassin June 26, 2023 21:14

Only guess update information for GitHub if environment variables exist

6755313

TheAssassin requested changes Jun 27, 2023

View reviewed changes

src/appimagetool.c Show resolved Hide resolved

src/appimagetool.c Show resolved Hide resolved

src/appimagetool.c Outdated Show resolved Hide resolved

src/appimagetool.c Outdated Show resolved Hide resolved

probonopd added 2 commits July 2, 2023 09:20

Implement change suggested by reviewer

59d507b

* github_repository_name regardless of owner_start * Move comment above if statement

Merge branch 'main' into feature-guess-github

db26eae

TheAssassin requested changes Jul 5, 2023

View reviewed changes

src/appimagetool.c Show resolved Hide resolved

Use snprintf

57b2c1d

#13 (review)